search

cbernet / cmgtools-lite

CMGTools as a subsystem, not as a CMSSW overlay
0 stars 0 forks source link

94 x htt #21

Closed GaelTouquet closed 6 years ago

cbernet commented 6 years ago

@steggema would you like to review?

steggema commented 6 years ago

so the reason you remove the muon scale factors is that they only apply to the single muon trigger + related offline selection and ID? it could still be good to keep them (and maybe just save their values in the output trees, not multiply them with the general event weight) if one wants to start doing data-MC comparisons soon. if the purpose is only synchronisation it's ok to drop them for now

GaelTouquet commented 6 years ago

yes the purpose is to drop them just for now since they are not final and the bins out of range messages slow down heppy

steggema commented 6 years ago

With "not final" you mean that these are not going to be the final scale factors we use? (since they are the final scale factors the muon POG will provide) If it's only the error messages that slow down heppy, we should reduce/omit those