search

cbernet / heppy

A python event processing framework for high energy physics based on ROOT
Other
8 stars 59 forks source link

Pfprototype: merged as requested and have run tests. #10

Closed alicerobson closed 8 years ago

cbernet commented 8 years ago

I'm done commenting. Everything looks very good! As soon as you are done taking my comments into account (or not if they are not relevant), I will merge, and we can start working towards removing aliceproto.

Thanks, let me know!

alicerobson commented 8 years ago

Thanks for the comments Colin I have addressed your comments and pushed the updated pfprototype branch up to my remote.

I have not moved any files out of aliceproto (yet) but can start thinking about it Alice

On 05 Apr 2016, at 16:28, Colin Bernet notifications@github.com wrote:

I'm done commenting. Everything looks very good! As soon as you are done taking my comments into account (or not if they are not relevant), I will merge, and we can start working towards removing aliceproto.

Thanks, let me know!

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/cbernet/heppy/pull/10#issuecomment-205833275