search

cbernet / heppy

A python event processing framework for high energy physics based on ROOT
Other
8 stars 59 forks source link

Update pfobjects.py #25

Closed MarinaBeguin closed 6 years ago

cbernet commented 8 years ago

coucou, tu me confirmes que c'est la bonne celle-la?

MarinaBeguin commented 8 years ago

Coucou,

oui c'est le bon fichier

Marina

2016-07-20 15:05 GMT+02:00 Colin Bernet notifications@github.com:

coucou, tu me confirmes que c'est la bonne celle-la?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/cbernet/heppy/pull/25#issuecomment-233942726, or mute the thread https://github.com/notifications/unsubscribe-auth/ATXKN4SiG9pKDIKvz5wcXH2wuw7YHzoeks5qXh0KgaJpZM4JQsdY .

cbernet commented 8 years ago

Salut Marina, je viens te tester et j'obtiens:

[test]$ ipython -i analysis_ee_ZH_cfg.py 0 
Python 2.7.11 (default, Jan 22 2016, 16:30:50) 
Type "copyright", "credits" or "license" for more information.

IPython 4.0.0 -- An enhanced Interactive Python.
?         -> Introduction and overview of IPython's features.
%quickref -> Quick reference.
help      -> Python's own help system.
object?   -> Details about 'object', use 'object??' for extra details.
  File "/Users/cbernet/Code/FCC/heppy/display/pfobjects.py", line 131
    super(GStraightTrajectory, self).__init__(description, linestyle=2, linecolor=1)
        ^
IndentationError: expected an indented block

Peux-tu essayer de ton cote et corriger?

Comme tu peux le voir, j'ai applique ces changements au-dessus de master : 

* 02fff53 5 hours ago Mariiina (HEAD, Mariiina-patch-1)
|         Update pfobjects.py
|  
* 126ed7c 31 hours ago Colin (colin/master, tutorial, master)
|         sequence now accepts either iterable (e.g. other sequences) or non-iterable objects
...
cbernet commented 8 years ago

@Mariiina

I tested the code, it works, nice! The color chosen for the electrons is too close to the one used for the photons. as a result, it's quite difficult to see them in a busy environment. See the attached display, which contains 2 electrons.

Electrons and muons are very important, they must jump to our eyes.

Could you please choose a very bright and visible color, different from yellow, that stands out?

At some point we should implement a style configuration file for the display so that everybody can choose what they want. But that's low priority.

electrons_not_visible