search

cbernet / heppy

A python event processing framework for high energy physics based on ROOT
Other
8 stars 59 forks source link

Papasevent #29

Closed alicerobson closed 7 years ago

alicerobson commented 8 years ago

Hi Colin

Pull request now OK to examine. One thing I know is not OK yet (would like to discuss) is the use of "if display" in the configuration files. My new "plotting" analyzers mean this probably requires some adaptation.

Thanks Alice

alicerobson commented 8 years ago

Hi Colin I think I have addressed almost all your comments. I have pushed my latest code.

There is still some sorting/thinking to do re BlockSplitter and a new analyzer for it. You were right about the graph analysis being repeated. Maybe we can cache it in the papasevent? We also need to discuss the propagators.

cbernet commented 7 years ago

Hi again, please make sure to merge my papasevent branch before pushing again.

alicerobson commented 7 years ago

Thanks for this Colin

I have done my best to address your comments on the eventplotter. I moved it into the display package but did not think it fitted in the display class. I have rationalised the interfaces as best I can.

I have also done some work on rationalising the dagplotter in a similar fashion. There is likely more to do.

I merged your papasevent and have pushed to mine.

Have a nice weekend Alice

On 04 Nov 2016, at 09:09, Colin Bernet notifications@github.com wrote:

Hi again, please make sure to merge my papasevent branch before pushing again.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cbernet/heppy/pull/29#issuecomment-258367308, or mute the thread https://github.com/notifications/unsubscribe-auth/ANqb2qgF68jT_-Jsgwz7uGiWdQPi_7m3ks5q6uhXgaJpZM4KZsLe.

cbernet commented 7 years ago

Hi Alice,

Thanks, let’s discuss on Monday the pending items, and in particular the reason why you think it does not fit in the display class. What about 10:30 in the morning?

Have a nice week-end too!

Colin

Le 4 nov. 2016 à 18:28, alicerobson notifications@github.com a écrit :

Thanks for this Colin

I have done my best to address your comments on the eventplotter. I moved it into the display package but did not think it fitted in the display class. I have rationalised the interfaces as best I can.

I have also done some work on rationalising the dagplotter in a similar fashion. There is likely more to do.

I merged your papasevent and have pushed to mine.

Have a nice weekend Alice

On 04 Nov 2016, at 09:09, Colin Bernet notifications@github.com wrote:

Hi again, please make sure to merge my papasevent branch before pushing again.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cbernet/heppy/pull/29#issuecomment-258367308, or mute the thread https://github.com/notifications/unsubscribe-auth/ANqb2qgF68jT_-Jsgwz7uGiWdQPi_7m3ks5q6uhXgaJpZM4KZsLe.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cbernet/heppy/pull/29#issuecomment-258496127, or mute the thread https://github.com/notifications/unsubscribe-auth/AD8kuzEpyfHTbc8OhmsnAaLre4AWBL0Kks5q62tRgaJpZM4KZsLe.