cbernet / heppy

A python event processing framework for high energy physics based on ROOT
Other
8 stars 59 forks source link

review impact parameter b tagging #44

Open cbernet opened 7 years ago

cbernet commented 7 years ago

Hi Nicolò (@nfoppiani),

I would like to use your btagging parametrization for the new detector models we're setting up in papas (namely CLIC and IDEA), as the parametrization of the resolution on the impact parameter is commonly given as a target for future detectors.

So I started to review your code and to work on a better integration.

First, I am going to separate the impact parameter smearing and the jet tagging, to put them in different analyzers. This will make it possible to run several jet tagging algorithms on the same tracks after smearing.

Second, there are a few points that are puzzling me, and you can find my questions and comments here: https://github.com/cbernet/heppy/compare/clic...for_nic They are marked with a COLIN->NIC tag

Could you please have a look? Then we can discuss these questions on skype if you want, or you can provide answers here if you prefer.

Based on my current understanding, the main items are the following:

Cheers & thanks in advance for your help!

Colin

nfoppiani commented 7 years ago

Hi Colin,

sorry for my late answer but I missed this mail.

Well, it is probably easier to discuss everything by skype, in particular the comments marked by COLIN->NIC.

For what concerns the three items:

Anyway I have a few ideas to improve the algorithm, we can also discuss them by Skype!

Cheers Nick