cbernet / heppy

A python event processing framework for high energy physics based on ROOT
Other
8 stars 59 forks source link

Suggestions from pypi PR #48

Open vvolkl opened 5 years ago

vvolkl commented 5 years ago

Hi Colin,

find here some suggested changes corresponding to my comments (also the changes of two of my PR's are in here). There is another issue: we decided to deprecated fcc-physics in one of the last meetings but I discovered it is still used for the JetClusterizer in heppy. I will move it to fcc-edm, where we also create a library + dictionary.

Installing proper executables with setup.py is trickier than I thought initially, mostly due to heppy_interactive. your current approach of writing a tmp_file also doesn't seem to work when you install heppy as a module, so I'm a bit out of my depth what a good solution could be!