search

cbeust / jcommander

Command line parsing framework for Java
Apache License 2.0
1.96k stars 334 forks source link

439 expand dynamic arg expands non dynamic args #440

Closed npetzall closed 10 months ago

npetzall commented 6 years ago

fixes issue #439

When looking the names loop wasn't duplicated in any validating fashion. So adding a handlesArg method wouldn't improve anything. Extracting a method might have been nice, but it would require three arguments.

mkarg commented 10 months ago

Nils, you force-pushed, but the result still is the same. Is this by intention?

npetzall commented 10 months ago

Nils, you force-pushed, but the result still is the same. Is this by intention?

I did so because I'm 5 years after master, so need to get all changes in.

mkarg commented 10 months ago

Nils, you force-pushed, but the result still is the same. Is this by intention?

I did so because I'm 5 years after master, so need to get all changes in.

That's fine, but do you also plan to fix the open issue I raised yesterday?

npetzall commented 10 months ago

@mkarg I would gladly solve it, if you could provide me with a way of testing the existing feature so that I can make sure that I'm not breaking it.

mkarg commented 10 months ago

Sorry for the delay and thank you very much for your contribution to JCommander, Nils! :-)