Fix PositiveInteger validator to reject 0

cbeust / jcommander

Command line parsing framework for Java

Apache License 2.0

1.96k stars 334 forks source link

Closed edenhochbaum closed 4 years ago

edenhochbaum commented 4 years ago

My sense is that the math / software community - in both technical and common use - has settled on the term "positive integer" as excluding 0.

@cbeust - do you disagree that this is the case?

this commit fixes #438

cbeust commented 4 years ago

Maybe so, but this fix could possibly break users by now so I don't feel comfortable merging this...