Open jtilahun opened 5 months ago
Feel free to file a PR if you like to get rid of the warnings. :-)
Looking around the codebase, I'm noticing that the SuppressWarnings
annotation is used in a few places in the codebase. In particular, @SuppressWarnings("unchecked")
appears in a few places. Are there any particular reasons for suppressing warnings as opposed to resolving the concerns that the warnings hint at? It's not clear whether the preference would be to suppress warnings or to try to actually resolve them. Frankly, it's not even clear whether the warnings are just noise or they're indicative of actual problems (which is itself worrisome).
If you feel uncomfortable with suppressed warnings, feel free to provide a PR that resolves the underlying problem.
I'm observing the following warning messages when running Copybara (which depends on JCommander):
I'm using
--java_runtime_version=remotejdk_11
in Bazel as suggested in https://bazel.build/docs/bazel-and-java#hermetic-testing. I'm also using JCommander commit 0525445 (the archive for which is pulled in Copybara commit 19ed647).