cbeust / kobalt

A Kotlin-based build system for the JVM.
Apache License 2.0
433 stars 60 forks source link

Proper CI for Linux / macOS / Windows #338

Closed sschuberth closed 7 years ago

sschuberth commented 7 years ago

The current "build failing" badge at the top of the README is not very encouraging when thinking about contributing to the project. Please ensure a properly working CI so PRs can be automatically checked at least against compile errors on the various platforms. If desired, I can assist with this.

pawegio commented 7 years ago

AFAIK kobalt moved to TeamCity, but I agree that this badge with failing status from travis does not encourage to contribute.

cbeust commented 7 years ago

Indeed. Kobalt is now built on TeamCity (because Travis was aborting for mysterious reasons). I'll fix the badge.

cbeust commented 7 years ago

Github doesn't seem to support TeamCity at the moment so I'm removing the badge for now.

sschuberth commented 7 years ago

I'd just like to emphasize that it's not about GitHub to support TeamCity, but about TeamCity to provide a GitHub integration. And from spending a few seconds on a Google search it looks like there are many ways to do that already.

cbeust commented 7 years ago

Thanks, I'll look into it!

-- Cédric

On Mon, Mar 13, 2017 at 12:51 AM, Sebastian Schuberth < notifications@github.com> wrote:

I'd just like to emphasize that it's not about GitHub to support TeamCity, but about TeamCity to provide a GitHub integration. And from spending a few seconds on a Google search it looks like there are many ways https://blog.jetbrains.com/teamcity/2013/02/automatically-building-pull-requests-from-github-with-teamcity/ to https://github.com/jonnyzzz/TeamCity.GitHub do https://github.com/JetBrains/commit-status-publisher that http://blog.petegoo.com/2015/03/14/teamcity-github/ already.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/cbeust/kobalt/issues/338#issuecomment-286036400, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFoom9TXkbeylPSD994XLArZMYHHryGks5rlPVqgaJpZM4MUAzd .

cbeust commented 7 years ago

@sschuberth It looks like all these solutions assume you're running your own TeamCity server.

Kobalt is being built on JetBrains' own TeamCity server so I don't have much control over this. Maybe they have some Github integration plug-ins installed, need to look into it.

sschuberth commented 7 years ago

@cbeust JetBrains' own commit-status-publisher says it's bundled since TeamCity 10.x, so if you're running at least that version nothing needs to be installed. I guess you should simply look whether the build feature is available to you.

cbeust commented 7 years ago

I turned on the commit status publisher and it's working fine for individual commits but not quite well for the README badge, take a look at the home page.

The URL is:

https://teamcity.jetbrains.com/app/rest/builds/buildType:(id:OpenSourceProjects_Kobalt_Build)/statusIcon

If I load it from my browser, I get the green badge but as you can see, there's an authorization problem when accessed from the README.md.

cbeust commented 7 years ago

Never mind, I figured it out:

image

sschuberth commented 7 years ago

It's looking good, but clicking the badge just shows the badge image. Would it be possible to make the badge link to the actual build log?

cbeust commented 7 years ago

Done.

sschuberth commented 7 years ago

Thanks, we're getting closer :-) Now is there a way for anonymous user to at least see the log?

cbeust commented 7 years ago

It should be public now.