search

cbeust / kobalt

A Kotlin-based build system for the JVM.
Apache License 2.0
433 stars 60 forks source link

* package all Kobalt sources in zip distribution. relates to #237 #411

Closed dmitry-zhuravlev closed 7 years ago

dmitry-zhuravlev commented 7 years ago

Hm... weird... I tried to execute "assemble" task several times and it build a valid distribution (on Windows):

kobalt-1.0.61/bin/kobaltw

kobalt-1.0.61/bin/kobaltw.bat

kobalt-1.0.61/kobalt/wrapper/kobalt-1.0.61.jar

kobalt-1.0.61/kobalt/wrapper/kobalt-1.0.61-sources.jar

kobalt-1.0.61/kobalt/wrapper/kobalt-wrapper.jar

On Thu, Apr 13, 2017 at 8:04 PM, Cedric Beust notifications@github.com wrote:

FYI this broke the distribution by omitting the top directory:

Archive: kobalt-1.0.60.zip Length Method Size Ratio Date Time CRC-32 Name

 197  Defl:N      158  20%  03-25-17 08:33  900ae185  kobalt-1.0.60/bin/kobaltw
 121  Defl:N       93  23%  02-08-17 09:54  2302adc3  kobalt-1.0.60/bin/kobaltw.bat

53708669 Defl:N 48586203 10% 04-11-17 10:47 1a407033 kobalt-1.0.60/kobalt/wrapper/kobalt-1.0.60.jar 11307 Defl:N 11005 3% 04-11-17 10:46 21a919ee kobalt-1.0.60/kobalt/wrapper/kobalt-wrapper.jar

53720294 48597459 10% 4 files

~/.kobalt/wrapper/dist [master]$ unzip -v kobalt-1.0.61.zip Archive: kobalt-1.0.61.zip Length Method Size Ratio Date Time CRC-32 Name

 197  Defl:N      158  20%  03-25-17 08:33  900ae185  kobaltw
 121  Defl:N       93  23%  02-08-17 09:54  2302adc3  kobaltw.bat

54042382 Defl:N 49017831 9% 04-13-17 09:58 a9154ba7 kobalt-1.0.61.jar 11235 Defl:N 10967 2% 04-13-17 09:57 d7df0980 kobalt-wrapper.jar 231090 Defl:N 205891 11% 04-13-17 09:59 a78c73cd kobalt-1.0.61-sources.jar

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cbeust/kobalt/pull/411#issuecomment-293961847, or mute the thread https://github.com/notifications/unsubscribe-auth/AGAYYQaO8eAhiH_4RgizdnGG-fDcuYuWks5rvlWdgaJpZM4M7YVj .

-- Best Regards, Dmitry Zhuravlev

cbeust commented 7 years ago

I deleted my comment because I was wrong, your change is fine, it's one of my changes before that that broke this.

dmitry-zhuravlev commented 7 years ago

Yep, I noticed that you deleted the comment but whatever sended the reply just to be sure ;)

On Fri, Apr 14, 2017 at 2:43 PM, Cedric Beust notifications@github.com wrote:

I deleted my comment because I was wrong, your change is fine, it's one of my changes before that that broke this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cbeust/kobalt/pull/411#issuecomment-294140512, or mute the thread https://github.com/notifications/unsubscribe-auth/AGAYYRdpF-vNhpT_Ytaq7rFx79V44S1rks5rv1vIgaJpZM4M7YVj .

-- Best Regards, Dmitry Zhuravlev