vcsTag not passed to Bintray

cbeust / kobalt

A Kotlin-based build system for the JVM.

Apache License 2.0

433 stars 60 forks source link

vcsTag not passed to Bintray #419

Closed ethauvin closed 7 years ago

ethauvin commented 7 years ago

Defined in Build.kt but not in kobalt-exec/0.6.4

cbeust commented 7 years ago

Looking at the bintray API doc, the tag is called vcs_tag:

{
  "desc": "This package...",
  "github_release_notes_file": "RELEASE_1.2.3.txt",
  "github_use_tag_release_notes": true,
  "vcs_tag": "1.1.5",
  "released": "ISO8601 (yyyy-MM-dd'T'HH:mm:ss.SSSZ)"
}

Kobalt captures it as

        class UpdateVersion(val desc: String?, val vcsTag: String?)

Maybe vcsTag is being marshalled to JSON as vcsTag and not vcs_tag?

ethauvin commented 7 years ago

Want me to look at that, and that is still on your radar?

cbeust commented 7 years ago

Go ahead.

Somebody recently complained I didn't tag the latest JCommander release so I'm interested in getting this fixed too :-)