cbeust / kobalt

A Kotlin-based build system for the JVM.
Apache License 2.0
432 stars 60 forks source link

fatJar are not always fat #429

Closed ethauvin closed 7 years ago

ethauvin commented 7 years ago

Using the following:

    assemble {
        jar {
            fatJar = true
        }

        mavenJars {}
    }

The jar created is definitely not fat, using publishToMavenLocal.

I would have said this would be a major issue with plugins, but as far as I can tell Kobalt now downloads plugins dependencies. Don't think there is a need to make plugins fat anymore.

Nevertheless, the issue remains.

ethauvin commented 7 years ago

Okay, the problem can be solved by doing:

    assemble {
        jar {
            fatJar = true
        }

        mavenJars {
            fatJar = true
        }
    }

It didn't used to be that way.

cbeust commented 7 years ago

This seems to be working as intended then.