search

cbeuw / Cloak-android

Android client of Cloak
Other
227 stars 32 forks source link

please increase versionCode with each release #41

Open IzzySoft opened 1 month ago

IzzySoft commented 1 month ago

Looks like you forgot to increase versionCode with the latest release – like the previous one, it still uses 22 there. versionCode is what Android uses internally to tell versions apart – so whoever has the previous release installed won't get an update notification for the current one as Android will think it is already there.

Thanks in advance!

linsui commented 1 month ago

It only has changes for F-Droid and reproducible. :) But I guess you can use fastlane metadata in this repo now.

IzzySoft commented 1 month ago

What does that have to do with versionCode, @linsui? A new release does not necessarily need Fastlane – but it must have the versionCode increased – which cannot be "healed" via Fastlane :stuck_out_tongue_winking_eye:

That said: look at full_description.txt here and compare it with the description at IoD, then you know why I have it disabled. Hint: fulldesc lacks the details :wink:

linsui commented 1 month ago

What does that have to do with versionCode, @linsui? A new release does not necessarily need Fastlane – but it must have the versionCode increased – which cannot be "healed" via Fastlane 😜

You can ignore the new tags since it doesn't have any new features but only some build script tweak for reproducible build. :)

That said: look at full_description.txt here and compare it with the description at IoD, then you know why I have it disabled. Hint: fulldesc lacks the details 😉

So would you like to PR your version? :)

IzzySoft commented 1 month ago

You can ignore the new tags

Does F-Droid's updater also ignore tags which correspond to the definition in the YAML now? :wink: But let's drop this topic, linsui – that was not advice to you but rather to Andy.

So would you like to PR your version? :)

If it's welcome, of course. So @cbeuw do you want to have it? See here for what it entails.