search

cbeuw / Cloak

A censorship circumvention tool to evade detection by authoritarian state adversaries
GNU General Public License v3.0
3.42k stars 303 forks source link

Make websocket url sub path configurable #216

Closed githablocal closed 1 year ago

githablocal commented 1 year ago

Fix #98

cbeuw commented 1 year ago

Thanks for the PR! Can you also update README to document this new option?

githablocal commented 1 year ago

BTW, I've stuck at generating linux binaries from github action. As I know little about golang, could you please check the error for me on https://github.com/githablocal/Cloak/actions/runs/4348756139/jobs/7597653835 ? During the Build phase, it says gox is not found, though it does get installed. Is it about some PATH configuration?

cbeuw commented 1 year ago

During the Build phase, it says gox is not found, though it does get installed

Looks like it's due to this CLI breaking change https://go.dev/doc/go-get-install-deprecation. I'll update the release script later, you don't need to worry about it, it's just for releases.

githablocal commented 1 year ago

Thank you. Now I can try and see if I can grab a quick binary into use before this PR gets merged.

githablocal commented 1 year ago

I think this reached its final state. I've force-pushed for reordering and merging the commits.