App crash when text is selected

cbeyls / fosdem-companion-android

FOSDEM Companion for Android

Apache License 2.0

138 stars 93 forks source link

App crash when text is selected #38

Closed flowolf closed 6 years ago

flowolf commented 6 years ago

We noticed a rare bug. The app crashes when text is selected and one switches between talks with a swipe.

the bugreport here includes a video. I was able to crash the app on Android 8.0.0 as well.

cbeyls commented 6 years ago

Thanks for the report. I noticed the same bug this year and didn't change anything specific in the layouts so I assume this is a bug in Android Oreo. Not sure how I can prevent it without disabling copy paste entirely.

flowolf commented 6 years ago

apparently the issue appears as early as Android Lollipop. see original bug report

cbeyls commented 6 years ago

It may be related to the support library then... I'll investigate again when I have time.

cbeyls commented 6 years ago

I went to the bottom of this issue and identified the cause. It turns out that text selection is using ArrowKeyMovementMethod internally, while in code I was additionally setting up a LinkMovementMethod in order to make links clickable. These two don't play well together.

To fix this I'll have to either:

Disable text selection
Disable clickable links
Implement a custom MovementMethod which handles both properly.

I'm investigating the last option.