Run gps from any directory (except MuJoCo experiments)

cbfinn / gps

Guided Policy Search

http://rll.berkeley.edu/gps/

Other

597 stars 239 forks source link

Run gps from any directory (except MuJoCo experiments) #13

Closed xinyutan17 closed 8 years ago

xinyutan17 commented 8 years ago

Run gps from any directory (except MuJoCo experiments)

Updated usage.md to reflect this
Refactored BASE_DIR / EXP_DIR in hyperparams files
Made comments better for load_pose_from_npz and save_pose_to_npz

xinyutan17 commented 8 years ago

Okay fixed, can I merge now?

cbfinn commented 8 years ago

Yes, though people should be aware that this breaks any of their non-checked in hyperparams files (and they need to change those two lines of code with the directory)

xinyutan17 commented 8 years ago

Should we just keep the old version then? I mean the extra "../" is kind of stupid but trivial.

cbfinn commented 8 years ago

Is there a clean way to make this change without affecting the hyperparams file?

xinyutan17 commented 8 years ago

Yes, those changes don't really do anything except make the code look a little better, so I can just remove them.

cbfinn commented 8 years ago

Ok, please do then.

On Sun, Apr 17, 2016 at 4:20 PM, Xin Yu Tan notifications@github.com wrote:

Yes, those changes don't really do anything except make the code look a little better, so I can just remove them.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/cbfinn/gps/pull/13#issuecomment-211127659