cbg-ethz / MC-CBN

MC-CBN performs large-scale inference on conjunctive Bayesian networks
GNU General Public License v2.0
4 stars 3 forks source link

Installation in R from github failed #7

Open TomLoosli opened 3 years ago

TomLoosli commented 3 years ago

Hi,

I'm trying to download the package from the github page to R (4.05) and i run into the following error message:

"C:/rtools40/mingw32/bin/"g++  -std=gnu++11 -I"C:/PROGRA~1/R/R-40~1.5/include" -DNDEBUG  -I'C:/Users/me/Documents/R/win-library/4.0/Rcpp/include' -I'C:/Users/me/Documents/R/win-library/4.0/RcppArmadillo/include' -I'C:/Users/me/Documents/R/win-library/4.0/RcppEigen/include'        -O2 -Wall  -mfpmath=sse -msse2 -mstackrealign -c add_remove.cpp -o add_remove.o
add_remove.cpp:10:10: fatal error: boost/graph/adjacency_list.hpp: No such file or directory
 #include <boost/graph/adjacency_list.hpp>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

The boost library is located in the BH package, which is not listed in the LinkingTo in the DESCRIPTION file. Could that be the issue here? Sorry, I'm rather new to this, in case more information is needed please let me know.

Thanks

sposadac commented 3 years ago

Thanks for reporting this issue. First, I would suggest to set up boost (see, e.g. https://www.boost.org/doc/libs/1_62_0/more/getting_started/windows.html) because currently the MC-CBN package expects the boost libraries to be installed on your system (https://github.com/cbg-ethz/MC-CBN#installation). To be able to use the BH package instead, one would probably need to modify the DESCRIPTION file as you suggested. Indeed, this could simplify the installation, so if you want to contribute with a PR, this will be welcome.

sposadac commented 3 years ago

I have started drafting the changes required to use BH. Could you please try if the PR #6 fixes this issue? I haven't tested devtools::install_github() and I don't expect it to work, so I suggest to follow the installation instructions. Thanks a lot!