wrong url for release download in quick install

cbg-ethz / V-pipe

V-pipe is a pipeline designed for analysing NGS data of short viral genomes

https://cbg-ethz.github.io/V-pipe/

Apache License 2.0

129 stars 43 forks source link

wrong url for release download in quick install #114

Closed Masterxilo closed 2 years ago

Masterxilo commented 2 years ago

https://github.com/cbg-ethz/V-pipe/blob/master/utils/quick_install.sh#L216 is wrong

the url for the tagged version tar archive is (now)

https://github.com/cbg-ethz/V-pipe/archive/refs/tags/v2.99.1.tar.gz

(with refs/tags)

and not just

https://github.com/cbg-ethz/V-pipe/archive/v2.99.1.tar.gz

DrYak commented 2 years ago

Weirdly, the old rets/tags/-less URL work again. Probably way too many people relied on that, and GitHub decided to bring the URL back. (Fun fact, we now run the tutorials automatically as part of our CI/CD so it's something that would be picked up in the future).

The main trouble we have now is that GitHub added yet another redirection on top, which:

wget (if available) will happily follow out-of-the-box.
curl (fall back on other OSes) will not, requiring -L option.

I'll fix both.

DrYak commented 2 years ago

fixed on rubicon in #b8e5c945d27572c0731154304defaf92f7c527c7 can you try it on your mac?