added CARNIVAL + differential gene expression and readded LDGM

cbg-ethz / dce

Finding the causality in biological pathways

https://cbg-ethz.github.io/dce/

10 stars 3 forks source link

Closed MartinFXP closed 3 years ago

MartinFXP commented 3 years ago

title + some minor additions/edits (e.g., help files, package suggests)

kpj commented 3 years ago

Any idea why the test (test-dce.R:219:3): different p-value computations work is failing? It's passing on master.

MartinFXP commented 3 years ago

Any idea why the test (test-dce.R:219:3): different p-value computations work is failing? It's passing on master.

The only change within the main part should be in the function topologically_ordering(). I don't see atm how that can influence the test.

Or maybe the match.arg function has some strange behaviour.

kpj commented 3 years ago

Shall I just merge this PR and see how it goes?

MartinFXP commented 3 years ago

Let's do one more round. Maybe it was just a glitch.

kpj commented 3 years ago

Seems like it didn't change 🤷

MartinFXP commented 3 years ago

I know whats going on. I'll have another go in a sec.

kpj commented 3 years ago

Nice! Good thing we have tests 😅 Should I merge it now?

MartinFXP commented 3 years ago

Sure.