Closed MaryamZaheri closed 7 years ago
I am making the code consistent with the most often used format, and will continue this on other files.
The most often used format within HaploClique or in C++land?
in HaploClique.
Hi Armin, what is the decision regarding this pull request?
Please see the comment that you haven't addressed yet.
On Apr 6, 2017 11:39 PM, "MaryamZaheri" notifications@github.com wrote:
Hi Armin, what is the decision regarding this pull request?
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/cbg-ethz/haploclique/pull/39#issuecomment-292331901, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXexlkuFlQ6NgPMSct0EkJWz4BchVaCks5rtVt8gaJpZM4Mvd_W .
I submitted a minor version as a draft. Please let me know if you have any comment.
Just increase the version in the CMakeLists.txt, how hard can that be?
Done.
After 1.0.1 comes 1.1.0
Sorry for the typo. Fixed.
Do we use different variable naming schemes throughout the code base or why the renaming from one convention to another?