search

cbg-ethz / haploclique

Viral quasispecies assembly via maximal clique finding. A method to reconstruct viral haplotypes and detect large insertions and deletions from NGS data.
GNU General Public License v3.0
25 stars 33 forks source link

1st CL for readability improvement #39

Closed MaryamZaheri closed 7 years ago

armintoepfer commented 7 years ago

Do we use different variable naming schemes throughout the code base or why the renaming from one convention to another?

MaryamZaheri commented 7 years ago

I am making the code consistent with the most often used format, and will continue this on other files.

armintoepfer commented 7 years ago

The most often used format within HaploClique or in C++land?

MaryamZaheri commented 7 years ago

in HaploClique.

MaryamZaheri commented 7 years ago

Hi Armin, what is the decision regarding this pull request?

armintoepfer commented 7 years ago

Please see the comment that you haven't addressed yet.

On Apr 6, 2017 11:39 PM, "MaryamZaheri" notifications@github.com wrote:

Hi Armin, what is the decision regarding this pull request?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/cbg-ethz/haploclique/pull/39#issuecomment-292331901, or mute the thread https://github.com/notifications/unsubscribe-auth/ABXexlkuFlQ6NgPMSct0EkJWz4BchVaCks5rtVt8gaJpZM4Mvd_W .

MaryamZaheri commented 7 years ago

I submitted a minor version as a draft. Please let me know if you have any comment.

armintoepfer commented 7 years ago

Just increase the version in the CMakeLists.txt, how hard can that be?

MaryamZaheri commented 7 years ago

Done.

armintoepfer commented 7 years ago

no

After 1.0.1 comes 1.1.0

MaryamZaheri commented 7 years ago

Sorry for the typo. Fixed.