cbg-ethz / shorah

Repo for the software suite ShoRAH (Short Reads Assembly into Haplotypes)
GNU General Public License v3.0
39 stars 14 forks source link

is shorah same as lofreq? #87

Open ibseq opened 1 year ago

ibseq commented 1 year ago

Hi all, does shorah algorithms follow the same principle as lofreq?

thanks Ibseq

DrYak commented 1 year ago

Not quite.

LoFreq is mostly done position wise:

ShoRAH at its core is a local haplotype caller, SNVs are a by-product of this:

ibseq commented 1 year ago

Hi thanks again. I’m aware that we can use a flag to specifically use lofreq instead of shorah to analyse the data, in that case which parameters from Lofreq are then chosen?

thanks ibseq

DrYak commented 1 year ago

The flag to select is in the section general, parameter snv_caller.

The parameter for lofreq are taken from the section lofreq (example), unlike the parameters of shorah wich are taken from section snv (example)

See the content of the file config/config.html in your local installation for a full reference of the configuration.

ibseq commented 1 year ago

thanks again, looking at the config file suggested for sars cov 2 it seems no parameters are used to custom lofreq . while I believe these can be added , does it imply that lofreq is run in default - see screenshot

thanks ibseq

Sent from Outlook for iOShttps://aka.ms/o0ukef


From: DrYak @.> Sent: Thursday, October 6, 2022 12:25 pm To: cbg-ethz/shorah @.> Cc: ibseq @.>; Author @.> Subject: Re: [cbg-ethz/shorah] is shorah same as lofreq? (Issue #87)

The flag to select is in the section general, parameter snv_caller.

The parameter for lofreq are taken from the section lofreq (examplehttps://github.com/cbg-ethz/pangolin/blob/6159461d926c677b80060e5c9fd2496cf6af6ffa/working/vpipe.config#L117), unlike the parameters of shorah wich are taken from section snv (examplehttps://github.com/cbg-ethz/pangolin/blob/6159461d926c677b80060e5c9fd2496cf6af6ffa/working/vpipe.config#L123)

See the content of the file config/config.html in your local installation for a full reference of the configuration.

— Reply to this email directly, view it on GitHubhttps://github.com/cbg-ethz/shorah/issues/87#issuecomment-1269851879, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH76DQ6VZMAUEXUHOPRAJQTWB2ZI5ANCNFSM6AAAAAAQBBVSFE. You are receiving this because you authored the thread.Message ID: @.***>