search

cbgaindia / ckanext-openbudgetsin_theme

Custom CKAN theme extension for Open Budgets India
https://openbudgetsindia.org/
MIT License
4 stars 0 forks source link

Code and clickable area 'key feature' cards #76

Closed vrnpi closed 3 years ago

vrnpi commented 3 years ago

The HTML code for cards in 'key features', and I'm not sure if this is the case everywhere, seems rather complicated. Here's the current code:

<div class="feature ml-24">
    <a href="https://openbudgetsindia.org/dataset?res_format=CSV" target="_blank">
        <span class="card-link-container"></span>
    </a>
    <div class="image-container dataset-icon">
        <!-- <img class="banner-image" alt="Explore machine readable Datasets" src="Key_features_icon-22.png"> -->
    </div>
    <div class="text-container mt-8">
        <h4>
            <a href="/dataset?res_format=CSV" target="_blank">
                Machine Readable Datasets
            </a>
        </h4>
    </div>
</div>

 The first couple of lines seems unnecessary?

<a href="https://openbudgetsindia.org/dataset?res_format=CSV" target="_blank">
    <span class="card-link-container"></span>
</a>

 Why are we doing this? Instead we could do the following,

<div class="feature ml-24">
    <a href="https://openbudgetsindia.org/dataset?res_format=CSV">
        <div class="image-container dataset-icon">
            <!-- <img class="banner-image" alt="Explore machine readable Datasets" src="Key_features_icon-22.png"> -->
        </div>
        <div class="text-container mt-8">
            <h4>
                <a href="/dataset?res_format=CSV" target="_blank">
                    Machine Readable Datasets
                </a>
            </h4>
        </div>
    </a>
</div>

Wrap the <a> tag around the content, that way we don't have to create pseudo span elements?