cbgaindia / ckanext-openbudgetsin_theme

Custom CKAN theme extension for Open Budgets India
https://openbudgetsindia.org/
MIT License
4 stars 0 forks source link

Semantic code for content #78

Open vrnpi opened 3 years ago

vrnpi commented 3 years ago

I noticed we aren't following semantic rules for HTML code on the website. We don't have an h1 tag on the homepage and we're incorrectly using h3 tags for 'paragraphs'. Here are a couple of instances I noticed

Given this, I'm assuming there might be more instances where we're not following the rules. Let me know if you want to do a code walk-through together and fix them.

shivamragnar commented 3 years ago

@vrnpi Sure we can sit for this but this we can take bit slower as it is there in the existing code, I am trying not to change existing HTML so we have the result. I will update about the progress on this.

vrnpi commented 3 years ago

@shivamragnar I don't understand.

We've changed a lot of code on the home page for some of the other components (like 'key features', 'budget basics', 'dashboards', etc.) so why can't we include it our scope, change, and push out something we know is not right. It would make the code more maintainable and rest assured we'll be setting a good precedent for future releases.