MSMSScans TopNoverN plot shows equally high bars for all 'N'

[cbielow]

e.g.

The reason is that MaxQuant switched from +/- in the identified column to + and `` (empty) since MaxQuant 2.x...

[czanetti]

hello, I get the error: Error in workerFcn(.self, df, ...) : unique(d_msmsScan$identified) %in% c("-", "+") non sono tutti TRUE (translation : "are not all true")

I installed the package with recent commits in this way

library(remotes)
install_github("cbielow/PTXQC",
               build_vignettes = TRUE, 
               dependencies = TRUE, ref = "r1.0.14")

MaxQuant Version 2.0.3.0

where do you think the issue could lie?

[cbielow]

Iäm a bit puzzled why this did not show up in my test data, but its pretty clear where the problem is. A fix is coming, but will take some days, since currently on vacation :)

[czanetti]

I tried to fix the problem (my first PR 😇), it worked for me. #122 Thanks for your great work !

[cbielow]

Awesome. Thanks! I will look into it when back from vacation (next weekend)

Am 05.09.2022 23:12 schrieb czan @.***>:

I tried to fix the problem (my first PR 😇), it worked for me. #122https://github.com/cbielow/PTXQC/pull/122 Thanks for your great work !

— Reply to this email directly, view it on GitHubhttps://github.com/cbielow/PTXQC/issues/119#issuecomment-1237459018, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABN27EW7RECL2B2UKSG5LW3V4ZOZLANCNFSM57L6L56A. You are receiving this because you authored the thread.Message ID: @.***>

[cbielow]

FYI: the reason I did not catch this, is that my MQ2.x dataset was run without dependent peptides. Hence the failing metric did not get invoked :/ Thanks for the fix!

[cbielow]

fixed in #120