search

cbielow / PTXQC

A Quality Control (QC) pipeline for Proteomics (PTX) results generated by MaxQuant
Other
42 stars 25 forks source link

Use named `guide` argument #135

Closed teunbrand closed 7 months ago

teunbrand commented 7 months ago

Hello there,

We have been preparing a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break PTXQC.

The issue is that we've harmonised most scales to have the name argument as the first argument. There were a few calls where a guide was passed as an unnamed argument and take up the place of the name argument. This PR fixes these calls to use a named argument for guides.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in https://github.com/tidyverse/ggplot2/issues/5588. We hope that this PR might help PTXQC get out a fix if necessary.

cbielow commented 7 months ago

This works as intended and captures all unnamed uses of guide AFAICT. Thanks for the PR!

teunbrand commented 7 months ago

Thanks for the swift response!