search

cbierman / SearchEngine

Class Project for Object Oriented Software Development
0 stars 1 forks source link

Line 31 in UserIndex.java #4

Open cgrycki opened 9 years ago

cgrycki commented 9 years ago

Line 31 UserIndex calls a method in Indexer called addField. I created method stub for this in Indexer last night since the method did not exist. Looking closer at it this morning though, my stub should be removed and I think either the add method should be renamed addField -or- line 31 in UserIndex should call the Indexer method.

cbierman commented 9 years ago

I don't think FieldSearch or Indexer are supposed to be called statically, especially when you look at Herman's example code. Database makes sense to be static since both Indexer and FieldSearch need to be adding and storing to the same Database.

hmmnd commented 9 years ago

So what changes should be made, if any?

cbierman commented 9 years ago

I would say the addField method is what should be implemented in the Indexer class if it's not already.

hmmnd commented 9 years ago

I made changes before I got your reply, sorry. I made the add field take in the identifier as well so that the database could be updated with them both. Should the addField still be implementing because if so I will definitely make the changes.

cbierman commented 9 years ago

That makes sense to me since the identifier will need to be used once you get that field

Sent from my Windows Phone

From: hmmndmailto:notifications@github.com Sent: ý10/ý24/ý2014 10:02 AM To: cbierman/SearchEnginemailto:SearchEngine@noreply.github.com Cc: Bierman, Cale Mmailto:cale-bierman@uiowa.edu Subject: Re: [SearchEngine] Line 31 in UserIndex.java (#4)

I made changes before I got your reply, sorry. I made the add field take in the identifier as well so that the database could be updated with them both. Should the addField still be implementing because if so I will definitely make the changes.

— Reply to this email directly or view it on GitHubhttps://github.com/cbierman/SearchEngine/issues/4#issuecomment-60399356.

cgrycki commented 9 years ago

Sorry Cale, it appears you are correct that we need FieldSearch objects. I will make the correction.

cbierman commented 9 years ago

No worries, it's always good to have people reviewing my code :smile: