Commented-out code - Githubissues

cbirdferrer / collatrix

this tool collates the outputs of the MorphoMetriX photogrammetry tool

MIT License

4 stars 2 forks source link

Commented-out code #5

Closed devarops closed 4 years ago

devarops commented 4 years ago

Please remove the commented-out code. Lines 2 and 19 of setup.py and lines 6, 12, 16, and 17 of meta.yaml are commented out. You can find more information about why that is considered a bad idea here:

Please, don’t commit commented-out code
Don’t share commented-out code

Review for the Journal of Open Source Software

cbirdferrer commented 4 years ago

Thank you for catching this! Those lines have been removed.

devarops commented 4 years ago

There is still some unnecessary text in:

requirements.txt

cbirdferrer commented 4 years ago

Ah yes sorry, thank you for catching that! It's been removed.

devarops commented 4 years ago

That looks good! :+1: :100: