search

cbitosc / cbitosc.github.io

Website for COSC
https://cosc.cbit.ac.in/
10 stars 26 forks source link

Added lazy loading of images #18

Closed coderwassananmol closed 4 years ago

r0mflip commented 5 years ago

Can you please rebase your code over master and make the required changes. Also move the attribute to the end as it feels neat.

coderwassananmol commented 5 years ago

Lazy loading not required for footer, coc and banner images

Let me know if the latest PR would work! :)

notlmn commented 5 years ago

👍 Proceed after rebase.

coderwassananmol commented 5 years ago

👍 Proceed after rebase.

Do I need to rebase with master? There are no conflicts per se.

notlmn commented 5 years ago

Do I need to rebase with master? There are no conflicts per se.

There's no issues, but it helps us have a clean git history.

coderwassananmol commented 5 years ago

Do I need to rebase with master? There are no conflicts per se.

There's no issues, but it helps us have a clean git history.

I have already made a merge commit. Rebasing with upstream/master is creating conflicts. Can you merge this PR with rebase strategy at your end?

r0mflip commented 5 years ago

@coderwassananmol There seems to be a layout issue, need to test. As we are AFK expect late replies.

coderwassananmol commented 5 years ago

@coderwassananmol There seems to be a layout issue, need to test. As we are AFK expect late replies.

No issues. Let me know when you test.