cbitstech / Purple-Robot

Sensing and automation platform for Android.
Other
38 stars 19 forks source link

PR actionbar item relabeled to "Friends & Family Info Needed", doesn't revert on probes disabled #206

Closed estory1 closed 10 years ago

estory1 commented 10 years ago

PR 1.4.7. Repro:

1) Enable HTTP Upload. 2) Enable probes (unsure precisely which one enables this item).. 3) Force an upload (probably unnecessary, but I did this before seeing the behavior). 4) Upload a few more times. 5) Disable all probes. 6) Disable HTTP Upload. 7) At some point, the PR actionbar item changes its text to "Friends & Family Info Needed" and the icon changes to a yellow-ish icon (this may have occurred prior to this point, but this is the point at which I noticed it).

However, when tapping on it, I'm not taken to some dialog or other UI area in which these values may be entered (or not-entered, as the user wishes). This makes some intuitive sense given that the probes are disabled, including the probe that would collect these values.

Though, I notice the actionbar item's text doesn't revert to its default state ("Application Status: Functioning normally..."). Not urgent, but it confused me a bit...

audaciouscode commented 10 years ago

If you scroll down, you’ll see some yellow text that will open up the people calibrator that will clear the warning once you’ve completed it.

If you don’t want to see the warnings, you can mute the status notifications in the settings.

-Chris

On Nov 14, 2013, at 2:13 PM, estory1 notifications@github.com wrote:

PR 1.4.7. Repro:

1) Enable HTTP Upload. 2) Enable probes (unsure precisely which one enables this item).. 3) Force an upload (probably unnecessary, but I did this before seeing the behavior). 4) Upload a few more times. 5) Disable all probes. 6) Disable HTTP Upload. 7) At some point, the PR actionbar item changes its text to "Friends & Family Info Needed" and the icon changes to a yellow-ish icon (this may have occurred prior to this point, but this is the point at which I noticed it).

However, when tapping on it, I'm not taken to some dialog or other UI area in which these values may be entered (or not-entered, as the user wishes). This makes some intuitive sense given that the probes are disabled, including the probe that would collect these values.

Though, I notice the actionbar item's text doesn't revert to its default state ("Application Status: Functioning normally..."). Not urgent, but it confused me a bit...

— Reply to this email directly or view it on GitHub.

estory1 commented 10 years ago

Good point; good to know.

Didn't see the yellow text on the actionbar menu. But I worked-around the notification by entering PR, tapping the notification icon, tapping the message about entering F&F data, and in the People Calibrator that opened, tagging a few people with the appropriate labels.

I still think the PR actionbar item's state was confusing at the point I experienced it, but if you prefer, feel free to close this issue.