cbitstech / Purple-Robot

Sensing and automation platform for Android.
Other
38 stars 19 forks source link

PR 1.10.14 and 1.10.12: config_data_server_uri in PR cfg not changing the HTTP Upload Endpoint #210

Closed estory1 closed 10 years ago

estory1 commented 10 years ago

In PRNM, the PR configuration can be updated via a call to the following function:

self.updatePurpleRobotConfiguration = function(jsonPrConfig) { var fn = "updatePurpleRobotConfiguration"; if(!this.CURRENTLY_IN_TRIGGER) { self = ctor.prototype; }
              self.debug('entered',fn);
              if(!self.isNullOrUndefined(jsonPrConfig)) {
                self.debug('Updating PR config using jsonPrConfig = ' + JSON.stringify(jsonPrConfig), fn);
                PurpleRobot.updateConfig(jsonPrConfig);
              }
              else { self.warn('Purple Robot configuration not updated; jsonPrConfig was null or undefined.', fn); }
              self.debug('exiting',fn);
            }

An example JSON doc that may be passed to this function:

{
  "config_restrict_data_wifi": "false",
  "config_data_server_uri": "https://SOME_HOST/prImporter"
}

In the above example configuration-to-update doc, the updatePurpleRobotConfiguration function successfully updates config_restrict_data_wifi (default value is true), but "config_data_server_uri" (the "HTTP Upload Endpoint" in PR) is not updated.

This of course has the end-user consequence that the upload endpoint must be configured manually for each device, for each institution that does not use our data-management infrastructure (as our URL is the default value)...

audaciouscode commented 10 years ago

After you updated the config URL, did you back out of the settings and come back in? New values are not displayed until the settings activity is started again.

-Chris

On Jan 3, 2014, at 2:40 PM, estory1 notifications@github.com wrote:

In PRNM, the PR configuration can be updated via a call to the following function:

self.updatePurpleRobotConfiguration = function(jsonPrConfig) { var fn = "updatePurpleRobotConfiguration"; if(!this.CURRENTLY_IN_TRIGGER) { self = ctor.prototype; } self.debug('entered',fn); if(!self.isNullOrUndefined(jsonPrConfig)) { self.debug('Updating PR config using jsonPrConfig = ' + JSON.stringify(jsonPrConfig), fn); PurpleRobot.updateConfig(jsonPrConfig); } else { self.warn('Purple Robot configuration not updated; jsonPrConfig was null or undefined.', fn); } self.debug('exiting',fn); } An example JSON doc that may be passed to this function:

{ "config_restrict_data_wifi": "false", "config_data_server_uri": "https://SOME_HOST/prImporter" } In the above example configuration-to-update doc, the updatePurpleRobotConfiguration function successfully updates config_restrict_data_wifi (default value is true), but "config_data_server_uri" (the "HTTP Upload Endpoint" in PR) is not updated.

This of course has the end-user consequence that the upload endpoint must be configured manually for each device, for each institution that does not use our data-management infrastructure (as our URL is the default value)...

— Reply to this email directly or view it on GitHub.

estory1 commented 10 years ago

Yep!

On Fri, Jan 3, 2014 at 2:42 PM, Chris Karr notifications@github.com wrote:

After you updated the config URL, did you back out of the settings and come back in? New values are not displayed until the settings activity is started again.

-Chris

On Jan 3, 2014, at 2:40 PM, estory1 notifications@github.com wrote:

In PRNM, the PR configuration can be updated via a call to the following function:

self.updatePurpleRobotConfiguration = function(jsonPrConfig) { var fn = "updatePurpleRobotConfiguration"; if(!this.CURRENTLY_IN_TRIGGER) { self = ctor.prototype; } self.debug('entered',fn); if(!self.isNullOrUndefined(jsonPrConfig)) { self.debug('Updating PR config using jsonPrConfig = ' + JSON.stringify(jsonPrConfig), fn); PurpleRobot.updateConfig(jsonPrConfig); } else { self.warn('Purple Robot configuration not updated; jsonPrConfig was null or undefined.', fn); } self.debug('exiting',fn); } An example JSON doc that may be passed to this function:

{ "config_restrict_data_wifi": "false", "config_data_server_uri": "https://SOME_HOST/prImporter" } In the above example configuration-to-update doc, the updatePurpleRobotConfiguration function successfully updates config_restrict_data_wifi (default value is true), but "config_data_server_uri" (the "HTTP Upload Endpoint" in PR) is not updated.

This of course has the end-user consequence that the upload endpoint must be configured manually for each device, for each institution that does not use our data-management infrastructure (as our URL is the default value)...

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/nupmmarkbegale/Purple-Robot-Manager/issues/210#issuecomment-31551986 .

Evan Story

audaciouscode commented 10 years ago

Do we have any evidence that this is still an issue?

estory1 commented 10 years ago

Not lately. We can reopen it if we see it again.