cbj252 / pe

0 stars 0 forks source link

Birthdays editing #6

Open cbj252 opened 10 months ago

cbj252 commented 10 months ago

Steps: edit a person's birthday to be a day between 1-31 but doesn't exist for that month (e.g. 30 Feb)

Result: birthday goes through with valid message, changing the person's birthday to the latest possible day of that month (so for the example: 28 Feb)

Expected: Program should give invalid input OR UG/program should state the change it's making

nus-pe-bot commented 9 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Specificity of error message when adding a date which does not exist (Such as in Feb)

Adding a date such as 30 Feb, which does not exist shows the same common error message. The error mentions its a format error, but instead could be more specific and mention that such a date does not exist.

Screenshot 2023-11-17 at 4.57.14 PM.png


[original: nus-cs2103-AY2324S1/pe-interim#663] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: My bug is talking about putting a person's birthday to an invalid date, succeeding and the system changes the person's birthday to a different valid date w/o any indication to the user this happened, either in the GUI or the UG.

The bug given is about putting an event's birthday to an invalid date, failing with an incorrect error message.

The two bugs start from different commands and the system treats them differently. The group did not give any reason why these two are similar.