search

cblanc / sws_gathers

NSL Gathers App
http://gathers.ensl.org
8 stars 9 forks source link

Feature of add a classic gather pool to the invitational one by voting #106

Open myxious opened 7 years ago

myxious commented 7 years ago

Adding a feature so players in the invitational gather can vote by clicking a button (like a regather one) to add a classic gather pool to one big pool. Read more: https://www.ensl.org/topics/1838

How to test manually: 1) uncomment the required lines in "/lib/user/helper.js" 2) RANDOM_USER=true npm run dev 3) first 8 "random" users will be members of invitational group

How to disable feature: "/lib/gather/gather.js" set 'this.ADDCLASSICPOOL_THRESHOLD' to 0

Since I am beginner web-developer I need your codereview ^_^

Absurdon commented 7 years ago

This is not gonna happen bruh. There is a reason for why they are seperated.

Absurdon commented 7 years ago

Sry i misunderstood what you were trying to do. Im gonna look through this code when I find the time.

myxious commented 7 years ago

sorry my english is shit so there is nothing surprising that you misunderstood ^___^