Merge patch-174-173 to master

[brcaswell]

Changes relating to npm start (handling babel-brunch compiling and development environment observations)

• updates node package versions to resolve #173
  • ensure devDependencies are defined as such
• modify url in packages.json to resolve #174;
• add "test-win" to npm script running, (relates to terminal \ host environment compatibility, as npm test will fail in cmd and powershell) will have to explicitly do npm run test-win to run script.
  • and modify env assignment for resiliency

resolves #173 resolves #174

[brcaswell]

What does that failed check relate to?

[Absurdon]

@cblanc can you check why this fails? Seems I don't have the permissions to do so.

[brcaswell]

@cblanc can you check why this fails? Seems I don't have the permissions to do so.

If I had to guess, I would think the failing check relates to steam package. As it seems to tentatively fail it's prepare script.

I looked into the package's source and project a bit, and I don't know why that package author is doing svn checkouts against github projects to begin with, but it would seem having a svn tool is an unspecified requirement

[cblanc]

Hey - i'd love to get back to this but I have no mental energy outside of work. I can only really offer some high level and probably less than useful pointers

There are 3 problems with this codebase - all of my own making

1. CI needs to be enabled. Although this project has some unit testing, it's not hooked up to a CI system
2. The project needs to be in a docker container. This will simplify local and production setup across envs. Something like this would suffice. Very simple, small + efficient. MongoDB has a very good stock docker image
3. Tests should also be completely dockerised. Like here. Again tests can be run in 1 command on any platform including CI

This solves a bunch of problems:

1. Anyone can make changes and test very quickly. Only a docker daemon is required (all available on MS, MacOS and Linux)
2. You can merge PRs quickly & with more confidence
3. Dev and prod env parity. No more works on this machine but not that
4. Dependency upgrades can be automated because CI
5. 1 command setup makes simple e2e tests very easy to setup if you need more confidence
6. This app needs to be moved off heroku because Mongodb service is shutting down. Would like to move to a low end VPS. Will be even cheaper and have better performance. Deployment and updates as simple as heroku if the app can be shipped as a docker container

[Absurdon]

Actually im planing on dockerizing this thing anyways. When it's docker we can just put it on jirikis machine so no need to pay an additional hoster. Sadly i dont have the time either. If anyone has go for it. I think november was the deadline for this.

[Absurdon]

when i did dockerization i merged this one in