feat: private threads - Githubissues

cblgh / cerca

lean forum software

Other

127 stars 18 forks source link

feat: private threads #66

Closed decentral1se closed 4 months ago

decentral1se commented 4 months ago

https://github.com/cblgh/cerca/issues/64

Manually tested it quite a bit.

I'm not sure what to do with the missing translations for other languages?

cblgh commented 4 months ago

@decentral1se this is amazing, really appreciate the incredibly quick turnaround! i'm merging this and adding the following tweaks as a kind of async collab (minor stuff):

using bool to represent private in function signatures wherever it's not imposed by sqlite lacking a bool type
probably tweaking isThreadPrivate to mitigate a potential crash? haven't tried it yet but not sure what the behaviour will be if someone puts in a threadId that is non-existent

cblgh commented 4 months ago

oh and re

I'm not sure what to do with the missing translations for other languages?

yeah don't sweat it, afaik cerca's not currently used in any language other than english? i feel divided on the i18n attempt, it's mainly introducing a lot of additional complexity without being that useful / fully supported. i often think about ripping it out

decentral1se commented 4 months ago

itsworking