search

cbm-fles / flesnet

CBM FLES Timeslice Building
7 stars 22 forks source link

Using namespace std #106

Closed cuveland closed 1 year ago

cuveland commented 1 year ago

The monitoring code has using namespace std; in the header (inside the cbm namespace). This pulls the whole std namespace then also into cbm algo. This is currently not a problem. But it could cause problems in the future because there are some functions and classes in the xpu library that could collide with the STL.

This issue was reported by @fweig.

cuveland commented 1 year ago

Background: The monitoring code was ported from the DCA framework, which imports std into the dca namespace. To emphasize the more general applicability of the monitoring code, the dca namespace was replaced by the cbm namespace.

To resolve the issue of namespace pollution, we should remove the "using namespace" directives from the code.

cuveland commented 1 year ago

Should be fixed by #107.