search

cbm-fles / flesnet

CBM FLES Timeslice Building
7 stars 22 forks source link

Monitoring: Fix possible types of MetricField. #114

Closed fweig closed 1 year ago

fweig commented 1 year ago

During DC July23, we discovered the MetricField definition causes some problems on older versions of Mac OS due to confusions between long and long long types.

This MR provides a fix by replacing the integer types with fixed size integers. Additionally I took the liberty to add some more types to MetricField that could be useful.

cuveland commented 1 year ago

Thanks for the MR, the contents looks good.

I am not quite sure why the formatting changed. Are you using a different version of clang-format?

More generally, did you set up the automatic formatting checks by running contrib/local-setup in your working copy? I admit that this may be poorly documented. ;-)

fweig commented 1 year ago

I used the clang-format installed on the fles login-node. Didn't know about contrib/local-setup, thanks!

Formatting changed because the column width of 80 characters was exceeded. (For the visit-block because of this line)

cuveland commented 1 year ago

Ah, thanks. You are right, of course.