search

cbm-fles / flesnet

CBM FLES Timeslice Building
7 stars 22 forks source link

Include libfabric in default build flow and fix CI #81

Closed fsalem closed 3 years ago

fsalem commented 3 years ago

When fles_libfabric is included, the build always fails. The reason is an error related to 'out of memory' errors. I propose limiting parallel processes up to 32

oTTer-Chief commented 3 years ago

Hi @fsalem ,

I tested your branch on my dev machine. It compiles now also with libfabric. Looks like the missing header fixed it. However there are some ISO C++ forbids variable length array warnings. They also show up I the CI. Could you please fix them or silence them if you consider it false positives.

fsalem commented 3 years ago

Hi @oTTer-Chief,

Yes, this header file fixed the compilation problem when Libfabric 1.6 is used, which is not the case with recent releases. However, even after considering this fix, the build always failed once fles_libfabric is included and it was due to memory limitations.

I fixed the warnings and the build is now free of warnings.

fsalem commented 3 years ago

@cuveland sorry, I forgot to use smart pointers. I will update it and send another PR.