search

cbmarcum / skeletal

A simple project creation tool that uses packaged templates
Apache License 2.0
17 stars 3 forks source link

Feature: add artifactory support #51

Closed bakomchik closed 5 months ago

bakomchik commented 6 months ago

Hi @cbmarcum ! Thanks for your lazybones supporting I just prepared feature to fetch packages from artifactory.

cbmarcum commented 6 months ago

Hi @bakomchik Thanks for the PR. There is a lot of work here and may take me some time to review. Please be patient and I'll let you know if I have any questions about it. Please let me know any additional information that might help as I don't use artifactory.

bakomchik commented 6 months ago

Hi @bakomchik Thanks for the PR. There is a lot of work here and may take me some time to review. Please be patient and I'll let you know if I have any questions about it. Please let me know any additional information that might help as I don't use artifactory.

Hi! Artifactory is an enterprise artifact storage https://jfrog.com/artifactory/ Like a maven nexus, but has more features The main part of implementation here https://github.com/cbmarcum/skeletal/pull/51/files#diff-49b663bb37ee90374ee0525d0ef1279c75ec787e930a2e3cc4ccf283b96545ef

cbmarcum commented 6 months ago

Hi @bakomchik , I have reviewed the code and I don't have any questions right now.
Thanks for this contribution!. The code looks very good. I'd be glad to add to the contributor list on the project page if you want. Just let me know how you would like it. Name and link if you want.