Pro-only icons aren't included in fa_icons.py

cboddy / i3-workspace-names-daemon

A daemon script to dynamically update workspace names in i3wm based on their content.

MIT License

117 stars 34 forks source link

Pro-only icons aren't included in fa_icons.py #3

Open sersorrel opened 5 years ago

sersorrel commented 5 years ago

I believe this is a list of all icons only available in Font Awesome Pro – as far as I can tell, none of them are in fa_icons.py.

cboddy commented 5 years ago

OK, but are the font-awesome pro icons in the debian package? If not it won't render them anyway.

You could check by trying to render a pro icon after installing the fonts-font-awesome package, if it works then we can update fa_icons with the pro icons too.

sersorrel commented 5 years ago

I assume they're not in the package, but given I've paid for the Pro icons I'd quite like to be able to use them, and I'd rather not have to use my own patched version of i3-workspace-names-daemon in order to do so.

kensand commented 5 years ago

If you can find another way to install a version of font awesome with the pro icons then it can probably be integrated with this script. If you can provide a list of their names and unicode values, then they can be added to fa_icons.py, but people without the pro icons would not be able to use them. So they should probably be put in a separate file that can be referenced for pro users.

cboddy commented 5 years ago

OK, that is interesting @anowlcalledjosh

I'm certainly open to supporting this, here is what I'd expect/suggest:

create/find/procure a list of the font-awesome pro-icon-names to unicode from the font-awesome website or similar; https://github.com/FortAwesome/Font-Awesome/tree/master/metadata might be helpful. Ideally store the pro-cons in a separate file to the free ones.
add a flag to the script to toggle using the pro icons
update the README with instructions for installing the package with the pro icons and a way to check if the pro-version is installed
a warning message if a pro icon-name is used in the config but the pro-flag is not enabled

sersorrel commented 5 years ago

Ok, I'll have a go at this.

@cboddy: How did you originally generate fa_icons.py? There's a JSON file describing all the icons (free and pro) at https://github.com/FortAwesome/Font-Awesome-Pro/blob/master/metadata/icons.json (only accessible with a licence), so assuming you used the free equivalent of that file to generate the list, then it should be possible for me to generate a list of free+pro icons in exactly the same way.