Closed cboettig closed 4 years ago
@jhpoelen still wondering if two different verbs would be better here, one for querying by content uri and a separate verb for querying by source location.
sources
(takes content uri and gives sources of content) and history
(gives history of content uri's seen at a given location). content
and origin
respectively. Also, as discussed in #15, return format may need both uuid
for the registration event (what SWH calls a 'visit', and (possibly) the content hash to the provenance recorded for the registry. These bits may be hidden (dropped from returned data.frame by default) for simplicity.
history
andsource
respectively. Maybe having two separate verbs for the two input types is better thanquery
?)identifier
,source
,date
. Currently no additional column to indicate which registry an entry is from).registries=
argument used byregister()
to support multiple registries, see #12.register
, the subroutinesquery_local()
andquery_remote()
are currently exposed, but I propose removing those since they are redundant and also not clear names.I think the return structure here is a key issue as well. It definitely makes sense to have a way to see all possible source locations for a given content identifier, rather than just one. But from a user interface perspective, it's often desirable to have a function that just returns one location out per content identifier in, which allows downloads. I thought that difference: returning a table vs returning a single URL, was the key motivation to add
retrieve
, but judging from #9 we're not on the same page there.