cboettig / contentid

:package: R package for working with Content Identifiers
http://cboettig.github.io/contentid
Other
46 stars 2 forks source link

query local first, return early on success #74 #75

Closed cboettig closed 3 years ago

cboettig commented 3 years ago

@noamross want to give this a quick spin? Should fix #74 by allowing resolve to return early if it finds a local match. Otherwise, it will check the remote registries.

codecov-commenter commented 3 years ago

Codecov Report

Merging #75 (0fe65dc) into master (3f17467) will increase coverage by 0.16%. The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   74.95%   75.12%   +0.16%     
==========================================
  Files          21       21              
  Lines         607      619      +12     
==========================================
+ Hits          455      465      +10     
- Misses        152      154       +2     
Impacted Files Coverage Δ
R/query_sources.R 88.88% <86.66%> (-1.28%) :arrow_down:
R/resolve.R 79.31% <100.00%> (+0.73%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f17467...0fe65dc. Read the comment docs.