search

cboettig / hugo-now-ui

:globe_with_meridians: Hugo adaptation of Now-UI from Creative Tim
http://cboettig.github.io/hugo-now-ui
MIT License
98 stars 61 forks source link

Modify example config #6

Closed tiggerk closed 6 years ago

tiggerk commented 6 years ago

Hello! I love this theme ❤️ ! Thank you for making it :) As I create a blog and apply this theme, I find some problems and send a PR. (Such as The unused directory occupies capacity)

cboettig commented 6 years ago

Thanks for the PR. Note that the docs/ directory is not unused, the rendered example site https://cboettig.github.io/hugo-now-ui/ builds there where it can be hosted directly from GitHub. (as you probably know GitHub Pages doesn't give many options on where one can put the sources). I do see your point about it bloating the repo though, I suppose we could move that over to a gh-pages branch instead.

tiggerk commented 6 years ago

@cboettig Oh, I didn't even think about it. So what do you think about removing the Makefile and adding themesDir option to config file?

cboettig commented 6 years ago

Closing this, but feel free to open a new issue to discuss any particular issues or proposals for changing the config. Recently revised site settings so that things should always at least build successfully with zero config required.