search

cboettig / knitcitations

:package: Generate citations for knitr markdown and html files
http://carlboettiger.info
Other
220 stars 28 forks source link

citep : superfluous space at the end #49

Closed youngser closed 10 years ago

youngser commented 10 years ago

Hi! In the "citep" example:

library(knitcitations) citep("10.3998/3336451.0009.101") citation already in database [1] "(<a href=\"http://dx.doi.org/10.3998/3336451.0009.101\">Bilder, 2006 )"

I don't like the extra space before ")". Is there reason for that? Is it possible to remove it ??

Thanks in advance.

sessionInfo() R version 3.0.2 (2013-09-25) Platform: x86_64-apple-darwin10.8.0 (64-bit)

locale: [1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] knitcitations_0.4-7 bibtex_0.3-6 knitr_1.5

loaded via a namespace (and not attached): [1] digest_0.6.3 evaluate_0.4.7 formatR_0.9 httr_0.2
[5] RCurl_1.95-4.1 stringr_0.6.2 tools_3.0.2 XML_3.95-0.2
[9] xtable_1.7-1

cboettig commented 10 years ago

Can you try the current dev version from github (knitcitations-0.5-0)?

youngser commented 10 years ago

Yay, it works!! Thanks!! I guess it's still in beta because it's not in CRAN ??

cboettig commented 10 years ago

I had hoped to add or tweak a few more features before pushing this one to CRAN (CRAN doesn't like getting updates more than every few months), but haven't gotten around to them so I'm pushing 0.5-0 to CRAN now.

Hoping to give knitcitations a more thorough overhaul at some stage to make it more flexible and easier to use, so suggestions and complaints welcome!

youngser commented 10 years ago

Great! I just started using it, so don't have much comment other than I'm loving it so far! As I'm getting used to it, I hope I can give you more comments/suggestions.

I guess you can close this for now. Cheers,

cboettig commented 10 years ago

Okay, I still have to fix this, (think I have a good way to improve all the formatting), but meanwhile I'm curious if you might prefer the pandoc-based solution I've just released to address #57? Since pandoc will be handling the final formatting of the inline citation, this should sidestep the issue. (Note that a pandoc markdown parser is set to become a standard part of RStudio as well).

cboettig commented 10 years ago

(Whoops, should have closed this earlier, as it is fixed even without pandoc)