cbopp-art / lightcase

The smart and flexible Lightbox Plugin.
https://cornel.bopp-art.com/lightcase/
Other
399 stars 106 forks source link

go to top issue #144

Closed bilios closed 6 years ago

bilios commented 6 years ago

Hello! Amazing work friend, i really love to play with lightcase!

I have an issue.. when i call pages to load, everything is fine but the parent goes to top. I tried to debug but it all happens when this line is triggered (line 188 of lightcase.js | _self._open();)

i cant seem to make it stay to the right place.. Any help?

my setup: $('.UpdateUserAccount').lightcase({ showSequenceInfo: false, fixedRatio: false,
transition: 'elastic', width: '90vw', height: '80vh', maxWidth: 900, maxHeight: 600, iframe: { width: '90vw', height: '80vh', frameborder: 0 } });

thanks man!

cbopp-art commented 6 years ago

Hi Thanks!

What exactly do you mean with “parent” goes top? That the page scrolls back to top?

Sent from my iPhone

On 16 Nov 2017, at 19:32, bilios notifications@github.com wrote:

Hello! Amazing work friend, i really love to play with lightcase!

I have an issue.. when i call pages to load, everything is fine but the parent goes to top. I tried to debug but it all happens when this line is triggered (line 188 of lightcase.js | _self._open();)

i cant seem to make it stay to the right place.. Any help?

my setup: $('.UpdateUserAccount').lightcase({ showSequenceInfo: false, fixedRatio: false, transition: 'elastic', width: '90vw', height: '80vh', maxWidth: 900, maxHeight: 600, iframe: { width: '90vw', height: '80vh', frameborder: 0 } });

thanks man!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

bilios commented 6 years ago

Hey!

I mean, i click a link with this code: < a class="UpdateUserAccount" data-rel="lightcase" href="newProduct.php">Add new product

and the lightcase set up i send you above, on the line i told you, suddenly the parent window move to the top! The lightcase window is playing correctly, but after i am closing it i have my user on top of the screen.

I tried to address it but i cannot..

I solved it with onInit (i take the pixels from the top) and onCleanup (i move all the page to the correct pixels), but its not the right way..

I don't know if it helps, but you can see the problem here, ** if you click the login (you can scroll some pixels so you can see that takes you again to the top). Its only a test but it will help you see the problem!

Thank you in advance and for your time friend!

cbopp-art commented 6 years ago

There is an error in your implementation. Lightcase can’t calculate dimensions, so it seems that your html is invalid. Maybe because you have the Doctype Declaration and tag not at the very first lines of your generated page. I have no other idea. :(

On 16 Nov 2017, at 21:11, bilios notifications@github.com wrote:

Hey!

I mean, i click a link with this code: Add new product <x-msg://32/newProduct.php> and the lightcase set up i send you above, on the line i told you, suddenly the parent window move to the top! The lightcase window is playing correctly, but after i am closing it i have my user on top of the screen.

I tried to address it but i cannot..

I solved it with onInit (i take the pixels from the top) and onCleanup (i move all the page to the correct pixels), but its not the right way..

I don't know if it helps, but you can see the problem here, http://symvoli.gr/eVid/index.php http://symvoli.gr/eVid/index.php if you click the login (you can scroll some pixels so you can see that takes you again to the top). Its only a test but it will help you see the problem!

Thank you in advance and for your time friend!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cbopp-art/lightcase/issues/144#issuecomment-345048102, or mute the thread https://github.com/notifications/unsubscribe-auth/ACov8zh7NfTDdmLHHbMUFPGCEUrKKRY-ks5s3JbigaJpZM4Qg78n.

bilios commented 6 years ago

You were right, html was bad, i corrected now the main errors but still.. I will try to find out.. Thank you anyway friend!

cbopp-art commented 6 years ago

ok, but i see that your html is still invalid. for instance, there is

inside the part.

On 16 Nov 2017, at 22:19, bilios notifications@github.com wrote:

You were right, html was bad, i corrected now the main errors but still.. I will try to find out.. Thank you anyway friend!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/cbopp-art/lightcase/issues/144#issuecomment-345065932, or mute the thread https://github.com/notifications/unsubscribe-auth/ACov86JrzIbD6lVr-gsqQGwEVQvFhJTaks5s3KbagaJpZM4Qg78n.

bilios commented 6 years ago

I cleaned everything! :) i am passing the w3c tests but still this occur.. Its really weird..

bilios commented 6 years ago

the solution was to remove html { overflow-y:scroll; } from the main CSS file!

Just in case someone else stumble on it! Case closed! :)

Thanks for your time man!

cbopp-art commented 6 years ago

@bilios Great!

aiac commented 5 years ago

the solution was to remove html { overflow-y:scroll; } from the main CSS file!

Just in case someone else stumble on it! Thank you, it worked for me after removeing html { overflow-y: auto; }