search

cbora / predictionio-template-java-universal-recommender

1 stars 9 forks source link

Testing #30

Open jk2227 opened 7 years ago

jk2227 commented 7 years ago

Have to do unit testing and integration testing!

Please comment on this thread with which components you will be testing

rhenwood39 commented 7 years ago

I'm going to test RDDUtils today

cbora commented 7 years ago

I'm going to do DataSource

cfifty commented 7 years ago

I'll test Preparator & Conversions

jk2227 commented 7 years ago

https://github.com/cbora/predictionio-template-java-universal-recommender/pull/34

Will get onto Query in the next day or two

rhenwood39 commented 7 years ago

ElasticSearch tesint framework: https://github.com/tlrx/elasticsearch-test

If we want to use it to test EsClient.

jk2227 commented 7 years ago

Testing for Query, Field, DateRange are done w/ Gson

AlgorithmParams & Algorithm should be next but I think it might be best for the ML team to handle @zhuyifan1996 & company

cfifty commented 7 years ago

Preparator Unit tests are done. Conversions unit tests is running into some problems with serializing BiDictionaryJava and its accompanying Scala immutable map. Since the integration tests are passing the conversions section without any trouble, I think we should hold off on finishing the Conversions unit tests until we decide there's a problem with conversions.