search

cboulanger / eventrecorder

A qooxdoo package that allows to record user interaction for replay in testing or presentations
https://cboulanger.github.io/eventrecorder/eventrecorder/
1 stars 5 forks source link

Uninformative test failure #7

Closed jaminfine closed 5 years ago

jaminfine commented 5 years ago

Upon playing a test that fails, the message is often uninformative. On screen a pop up will say:

Cannot read property 'fireEvent' of undefined

A warning is logged in the console with slightly more information:

008882 cboulanger.eventrecorder.player.Qooxdoo[1041-0]: TypeError: Cannot read property 'fireEvent' of undefined
eval at <anonymous>

It would be helpful if the test failure message would say which line of the test script caused the failure.

cboulanger commented 5 years ago

True, this is unhelpful. If you set the environment variable "qx.debug" to true and use one of the qooxdoo loggers, you should be seeing much more, since the logging is quite extensive (see here). However, information on the line of the script could certainly be added to the command execution and for macros and imports.

cboulanger commented 5 years ago

@jaminfine Error reporting should be improved by https://github.com/cboulanger/eventrecorder/commit/3932f970205743a7a4ec363984ac302ba4c983a6 , please report if this solves your problem and close the issue if it does.

jaminfine commented 5 years ago

This makes it much clearer where a test fails! This definitely solves the issue