search

cboulanger / qx-contrib-Dialog

A set of often used dialog widgets for the qooxdoo framework (deprecated, use qooxdoo/qxl.dialog instead)
6 stars 10 forks source link

Added support for CheckBoxes to the Dialog's form component #1

Closed omrihar closed 12 years ago

omrihar commented 12 years ago

This is a very simple implementation of CheckBoxes. Simply added them with the Label component as the CheckBox's text. Then when added, made sure the checkbox gets a colSpan of 2.

Hope this is good enough to help :)

Omri

cboulanger commented 12 years ago

This is cool. So much better than applying a diff.

cboulanger commented 12 years ago

While you're at it, would you add an example to the demo application's form demo? Thanks!

cboulanger commented 12 years ago

And many thanks for the addition, by the way!

omrihar commented 12 years ago

Sure, I will have a look at it later today and create another pull request. This was actually my first pull-request :) Seems to have worked well!

cboulanger commented 12 years ago

HI, did you find the time to amend the demo? Then I could create a first GitHub release...

Thanks, C.

2012/8/14 omrihar notifications@github.com

Sure, I will have a look at it later today and create another pull request. This was actually my first pull-request :) Seems to have worked well!

— Reply to this email directly or view it on GitHubhttps://github.com/cboulanger/qx-contrib-Dialog/pull/1#issuecomment-7723989.

omrihar commented 12 years ago

Hi Christian,

no I didn't manage to do it yet, I will do it today though..

Cheers, Omri

On Sun, Aug 26, 2012 at 8:59 PM, Christian Boulanger < notifications@github.com> wrote:

HI, did you find the time to amend the demo? Then I could create a first GitHub release...

Thanks, C.

2012/8/14 omrihar notifications@github.com

Sure, I will have a look at it later today and create another pull request. This was actually my first pull-request :) Seems to have worked well!

— Reply to this email directly or view it on GitHub< https://github.com/cboulanger/qx-contrib-Dialog/pull/1#issuecomment-7723989>.

— Reply to this email directly or view it on GitHubhttps://github.com/cboulanger/qx-contrib-Dialog/pull/1#issuecomment-8035837.