Prompt/Alert: focus on appear, Enter/Esc keys, jsLint

cboulanger / qx-contrib-Dialog

A set of often used dialog widgets for the qooxdoo framework (deprecated, use qooxdoo/qxl.dialog instead)

6 stars 10 forks source link

Prompt/Alert: focus on appear, Enter/Esc keys, jsLint #6

Closed franck34 closed 11 years ago

franck34 commented 11 years ago

Hi christian

Here is my no breaking (mhh i hope so) changes purposal :

Alert: focus OK Button on appear
Prompt: focus textField on appear, handle Esc and Enter keys
Dialog: add jslint ignore respecting qooxdoo > 2.x syntax

Cheers

cboulanger commented 11 years ago

Hi! Thanks for your modifications! This all seems like it would have no side effects, but have you compiled and run the test app successfully (i.e., clicked through all the dialogs)? Once you have confirmed this, I will merge the pull request.

franck34 commented 11 years ago

I did, but i didn't clicked trhrought all dialogs, please wait a few minutes, doing it right now (note i'm using qx 2.1.1)

franck34 commented 11 years ago

Found a little bug, not related to tests/side effects, fixed.

I've compiled demo and i've play with all boxes, it's ok for me ;)

I've probably purpose stuff more later without breaking things.

Thanks Christian !