Closed themoenen closed 11 months ago
I fixed some of the tests but there are a couple more that I need to go through so the pipeline might still fail, will try to go through the rest either monday or wednesday
Merging #55 (07f3aad) into master (2d3f2c9) will decrease coverage by
0.30%
. The diff coverage is92.30%
.
Okay the test pipeline should pass now and the docs build as well. I just have two nitpicky comments which are related:
Edit: I took care of the background, I still need to update a few things (updating the changelog and the demo image, hopefully today) before merging. I'll take care of the info button update as well this weekend if I have time, then merge and prerelease so that people can give it a go before the actual release!
Thanks again @themoenen for the awesome contribution!
I'll make sure to implement the info button feedback, but I may wrap this up with some other improvements that come out of testing later, so for now I will have to put this aside.
Major refactoring
Responsiveness: the grid as well as all UI components are now fully responsive, up until around ~415px wide. Smaller usage seems unlikely.
Iframe usage:
use_iframe
has been added to override the default behavior.width
andheight
have been renamed toiframe_width
andiframe_height
to more descriptive.Templates: the
pages
/table
templates and corresponding functions have been renamed tointeractive
/static
for clarity.Interactive navigation components (pagination, sort, search, select menu):
Grid improvements:
gap
parameter (which controls the gap between cells) is set to 0, a negative margin ensures we avoid double borders in between cells, resulting in a tighter look.pad
for controlling the padding of each cell.ENTER
/ESC
for selecting / unselecting,←
/→
for navigation.n_items_per_page
parameter has been added, replacingn_cols
for the interactive template.n_items_per_page
is set to a different number, the grid will just display a gap at the end of the page.size[0]
and the number of columnsn_cols
. This way there's optimal overlap with how the interactive grid works.Data display:
subbet
ortooltip
can now be copied by clicking them.truncate
lets you override the default truncating behavior. Note: whentruncate
is set toFalse
, longer values will distort the grid, causing a more chaotic layout, but otherwise this doesn't affect the functionality.Tooltip
tooltip_trigger
default value is nowfocus
.tooltip_trigger
parameter has been removed, the tooltip is now controlled by JS (SeeinitToolTip
ingrid_interaction.js
).Popup
max-width: 80%
is no longer needed as default styling.Small improvements
img
to the subset without throwing an error (previous behavior: throw error and tell user to add it.)img
into the subset list, if you want to change the order of the data parameters and the image.;
as delineator instead of a tab\t
. This way CSVs are properly previewed on Mac.Bug fixes
gap
in static template didn't work.iframe_height
is set by the display function.height="200"
because it didn't serve any purpose.cell_width
parameter as it was being overwritten and not documented.custom_css
parameter instructions 'Only available for the "interactive" template' because it's not.